Skip to content

Conversation

@qwfy
Copy link
Contributor

@qwfy qwfy commented Feb 28, 2020

Two CLI options are added to install.sh:

  • --no_sudo runs all commands without sudo
  • --pip_mirror allows the user to set the pip mirror

with these two options, user can install deepspeed to their conda environment.

@msftclas
Copy link

msftclas commented Feb 28, 2020

CLA assistant check
All CLA requirements met.

@ShadenSmith
Copy link
Contributor

Hello! Thank you very much for your contribution to DeepSpeed.

For most users, we are thinking that the no-sudo case is the wanted one. Would you mind inverting the default behavior and instead using a --sudo flag?

@qwfy
Copy link
Contributor Author

qwfy commented Mar 1, 2020

@ShadenSmith Done. Except that the option is named --pip_sudo, which is only effect for pip commands, not --sudo, considering some other installation procedures (e.g. write some config to /etc/) may also requires sudo, and the user may want to run pip without sudo, but allow writing to /etc/ with sudo.

@jeffra
Copy link
Collaborator

jeffra commented Mar 1, 2020

This looks good, we’ll have to update a few parts of our tests to get this to pass. Will do that tomorrow and then we can get this merged in.

@jeffra
Copy link
Collaborator

jeffra commented Mar 5, 2020

@jeffra jeffra merged commit 5f6294b into deepspeedai:master Mar 9, 2020
@ShadenSmith
Copy link
Contributor

Hi @qwfy , thank you very much for the contribution.

We have a now have a conda package uploaded and we appreciate any feedback :-).

We have versions compiled for cudatoolkit versions 10.0 and 10.1 To install along with pytorch and other dependencies that are in the conda-forge channel:

conda install deepspeed cudatoolkit=10.1 -c deepspeed -c pytorch -c conda-forge

kouml pushed a commit to kouml/DeepSpeed that referenced this pull request Apr 3, 2020
…epspeedai#113)

* Add --no_sudo to run without sudo

* Add --pip_mirror to set the pip mirror

* Default to running pip without sudo

* Typo

* Add --pip_sudo to Dockerfile and azure-pipelines.yml

Co-authored-by: Jeff Rasley <jerasley@microsoft.com>
delock added a commit to delock/DeepSpeedSYCLSupport that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants