Fix global_steps checkpoint loading. #139
Merged
+56
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The PR tests aren't triggering for some reason. Investigating. |
jeffra
requested changes
Mar 15, 2020
Collaborator
jeffra
left a comment
jeffra
left a comment
There was a problem hiding this comment.
Can we add a test that triggers this bug? Maybe even testing all (or most) of these keys? I think it should be just a checking save and load that would work.
ShadenSmith
force-pushed
the
ckpt_steps_var
branch
from
b6a3fc9 to
34677df
Compare
Contributor
Author
|
Finally got around to flushing out some tests. We now explicitly test for those deepspeed states like |
tjruwase
approved these changes
May 5, 2020
jeffra
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.