Switch to use or not einsum op. Needed for ORT#1456
Merged
Conversation
ganik
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
Contributor
Author
|
Trying draft PR first to see if there are any build breaks |
Collaborator
|
Thanks for the contribution @ganik, the formatting tests that are failing can be fixed via these instructions: https://github.com/microsoft/DeepSpeed/blob/master/CONTRIBUTING.md#prerequisites |
Contributor
|
@ganik Can ORT support einsum? Einsum is becoming more universal especially in the context of MoE. |
Contributor
Author
Yes, we are looking into this, its not easy to make it performant. Einsum is a sort of UBER op where depending on rule it branches out to different translations. |
ganik
changed the title
Collaborator
jeffra
approved these changes
Oct 21, 2021
Collaborator
jeffra
left a comment
jeffra
left a comment
There was a problem hiding this comment.
LGTM, waiting for review from MoE folks though.
Contributor
Contributor
|
LGTM! |
Dipet
pushed a commit
to Dipet/DeepSpeed
that referenced
this pull request
Oct 26, 2021
Co-authored-by: Gani Nazirov <ganaziro@microsoft.com> Co-authored-by: Gani Nazirov <ganaziro@OrtTrainingDev4.af05slrtruoetgaxwwjv5nsq5e.px.internal.cloudapp.net> Co-authored-by: Jeff Rasley <jerasley@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace einsum op as its not supported by onnxruntime.
Branch by USE_EINSUM flag.
Example:
...
deepspeed.moe.sharded_moe.USE_EINSUM = False
...
self.fc3 = deepspeed.moe.layer.MoE(..)
...