[doc] fix typos and add improvements #1463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas00
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
tjruwase
approved these changes
Oct 20, 2021
Contributor
|
Squashing before CI unit tests complete since this is a docs PR. |
Collaborator
Author
|
@tjruwase, do you need to manually update https://deepspeed.readthedocs.io/en/stable/memory.html |
Contributor
|
No, it is automatically updated. Perhaps give it a bit of time. |
Contributor
|
Actually, it has been two days right? Hmm, this means something might be wrong. I will take a closer look. |
Collaborator
Author
|
it was merged 2 days ago, if it hasn't automatically updated it's unlikely it would ;) |
Collaborator
Author
|
Also I noticed it needs to be further updated to use the latest names of the offload config as it currently uses the deprecated cpu_offload, cpu_offload_params |
Contributor
|
I will add to my TODO. |
Collaborator
Author
|
You're the best, @tjruwase! |
Dipet
pushed a commit
to Dipet/DeepSpeed
that referenced
this pull request
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the memory doc this PR fixes broken formatting and adds an important note from @samyam to why fp16 gradients consume 4 bytes instead of 2.
@tjruwase