Skip to content

[zero-3] add bwd support for list/dict types returned in fwd#1857

Merged
jeffra merged 17 commits intomasterfrom
jeffra/z3-list-fix
Apr 26, 2022
Merged

[zero-3] add bwd support for list/dict types returned in fwd#1857
jeffra merged 17 commits intomasterfrom
jeffra/z3-list-fix

Conversation

@jeffra
Copy link
Collaborator

@jeffra jeffra commented Mar 23, 2022

Currently if a forward pass returns a list or dict zero-3 will skip the backward pass on any Tensors that are embedded in the structures.

@jeffra jeffra marked this pull request as ready for review March 23, 2022 17:19
@jeffra jeffra changed the title [zero-3] add support for list type in fwd [zero-3] add bwd support for list/dict types returned in fwd Mar 23, 2022
Copy link
Contributor

@samyam samyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just left a few minor comments.

@jeffra jeffra merged commit a52cbf8 into master Apr 26, 2022
@jeffra jeffra deleted the jeffra/z3-list-fix branch April 26, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants