Specify num_replicas and rank when creating sampler#216
Merged
ShadenSmith merged 3 commits intodeepspeedai:masterfrom Jun 4, 2020
Merged
Specify num_replicas and rank when creating sampler#216ShadenSmith merged 3 commits intodeepspeedai:masterfrom
ShadenSmith merged 3 commits intodeepspeedai:masterfrom
Conversation
ShadenSmith
suggested changes
May 27, 2020
Contributor
ShadenSmith
left a comment
ShadenSmith
left a comment
There was a problem hiding this comment.
Looks good! Just a minor comment.
ShadenSmith
approved these changes
Jun 2, 2020
Contributor
|
Thanks @vidushv! This looks good. I'll merge after the tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue #99. If
mpuis provided todeepspeed.initialize(), then pass on the world size and rank information toDistributedSamplerto ensure multiple processes will load the appropriate subset of the original dataset.