readthedocs yaml configuration#410
Merged
jeffra merged 24 commits intodeepspeedai:masterfrom Sep 17, 2020
Merged
Conversation
added 14 commits
September 14, 2020 15:44
ShadenSmith
added
dependencies
ShadenSmith
requested review from
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz and
niumanar
as code owners
ShadenSmith
requested review from
RezaYazdaniAminabadi,
samyam and
tjruwase
as code owners
jeffra
reviewed
Sep 15, 2020
|
|
||
| # Optionally build your docs in additional formats such as PDF | ||
| formats: | ||
Collaborator
There was a problem hiding this comment.
Will this actually build the docs somewhere in PDF? interesting
Contributor
Author
There was a problem hiding this comment.
jeffra
approved these changes
Sep 15, 2020
arashashari
approved these changes
Sep 15, 2020
Contributor
arashashari
left a comment
arashashari
left a comment
There was a problem hiding this comment.
Please check the failing test, otherwise LGTM, and thanks for handling it.
Collaborator
|
Seems it's failing with this import for some reason: https://github.com/microsoft/DeepSpeed/blob/91b4a93db01318cf7ad39b33ee3b2d2715abac54/deepspeed/ops/__init__.py#L1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.