Pipeline warnings and checkpoint portability#588
Merged
ShadenSmith merged 3 commits intodeepspeedai:masterfrom Dec 8, 2020
Merged
Pipeline warnings and checkpoint portability#588ShadenSmith merged 3 commits intodeepspeedai:masterfrom
ShadenSmith merged 3 commits intodeepspeedai:masterfrom
Conversation
ShadenSmith
requested review from
RezaYazdaniAminabadi,
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
jeffra
approved these changes
Dec 8, 2020
Collaborator
jeffra
left a comment
jeffra
left a comment
There was a problem hiding this comment.
Looks good, but can we add a test case that covers the checkpoint bug?
Contributor
Author
|
Good point. Our pipeline checkpoint suite already covers this in a way. This change that returns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
allreduce_gradientsargument tobackward()