Skip to content

Support legacy optimizer fusion as config option#75

Merged
tjruwase merged 8 commits into
masterfrom
olruwase/legacy_optimizer_fusion
Feb 22, 2020
Merged

Support legacy optimizer fusion as config option#75
tjruwase merged 8 commits into
masterfrom
olruwase/legacy_optimizer_fusion

Conversation

@tjruwase
Copy link
Copy Markdown
Contributor

New apex, version 0.1.0, implements a new style of optimizer fusion while deprecating the old style. This PR provides support for both old and new fusion styles as a configuration option.

@tjruwase tjruwase linked an issue Feb 13, 2020 that may be closed by this pull request
@tjruwase
Copy link
Copy Markdown
Contributor Author

Tested with the latest apex 0.1.0 and pytorch 1.3.1 and 1.4.

@jeffra
Copy link
Copy Markdown
Collaborator

jeffra commented Feb 20, 2020

We talked offline but adding comment here too. Can we test PyTorch 1.2 with the latest version of Apex (commit 50338df62). Unfortunately Apex doesn't do any versioning so we have to refer to specific commit hashes (the code has been at version 0.1.0 since the beginning).

If this commit works we can update our submodule to point to commit 50338df62 and update our docs to show we support PyTorch 1.2, 1.3, and 1.4 which would be awesome. Each PyTorch version has it's own assumptions on CUDA/CuDNN versions but we don't know what Apex itself has in terms of CUDA/CuDNN dependencies.

We should be able to test PyTorch 1.2 + commit 50338df62 of Apex with our current DeepSpeed docker image (which uses CUDA 10.0).

@tjruwase
Copy link
Copy Markdown
Contributor Author

Tested with pytorch 1.2 + new apex.

@tjruwase tjruwase merged commit 6d60206 into master Feb 22, 2020
kouml pushed a commit to kouml/DeepSpeed that referenced this pull request Apr 3, 2020
* Support legacy optimizer fusion as config option

* Configure for legacy optimizer fusion

* Update configuration jsons for new apex
rraminen pushed a commit to rraminen/DeepSpeed that referenced this pull request Apr 28, 2021
@jeffra jeffra deleted the olruwase/legacy_optimizer_fusion branch September 24, 2021 04:41
delock pushed a commit to delock/DeepSpeedSYCLSupport that referenced this pull request Sep 21, 2022
pengwa pushed a commit to pengwa/DeepSpeed that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support old and new apex optimizer fusion

3 participants