Support new python 3.14 annotation handling#7831
Merged
tohtana merged 6 commits intodeepspeedai:masterfrom Feb 10, 2026
Merged
Conversation
sdvillal
requested review from
hwchen2017,
loadams,
tjruwase and
tohtana
as code owners
closes deepspeedai#7673 Signed-off-by: Santi Villalba <sdvillal@gmail.com>
sdvillal
force-pushed
the
py3.14-compat
branch
from
e6b88cc to
fa50c7c
Compare
This was referenced Feb 5, 2026
tohtana
reviewed
Feb 6, 2026
tohtana
reviewed
Feb 6, 2026
tohtana
reviewed
Feb 6, 2026
Collaborator
|
Thank you @sdvillal! |
tohtana
reviewed
Feb 7, 2026
Collaborator
|
Sorry, can you fix the annotations to |
Signed-off-by: Santi Villalba <sdvillal@gmail.com>
sdvillal
force-pushed
the
py3.14-compat
branch
from
9a3e586 to
5cbad9e
Compare
this does not force the caller to provide the type, hopefully it is not surprising Signed-off-by: Santi Villalba <sdvillal@gmail.com>
…f annotationlib.get_annotations Signed-off-by: Santi Villalba <sdvillal@gmail.com>
sdvillal
force-pushed
the
py3.14-compat
branch
from
fbf8def to
3111e9f
Compare
tohtana
reviewed
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current metaclasses for layers and parameters access annotations in a way that is incompatible with python 3.14+
See:
This PR uses annotationlib from python 3.14 onwards and keeps backwards compatibility.
closes #7673
should unblock CF builds for py3.14 conda-forge/deepspeed-feedstock#114
A question is, does deepspeed support officially 3.14 yet? Should we test it in CIs?