[SPIR-V] Add payload to OpEmitMeshTasksEXT#7485
Merged
Keenuts merged 1 commit intomicrosoft:mainfrom May 30, 2025
Merged
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
This commit fixes the missing payload parameter for the OpEmitMeshTasksEXT instruction. Errors such as the passed variable storage class or type are already tested. Fixes microsoft#7082 Co-Authored-by: baldurk <baldurk@baldurk.org>
s-perron
approved these changes
May 29, 2025
Collaborator
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
Interesting that the variable is assigned to, but never used. I would have expected a warning about this causing a failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the missing payload parameter for the OpEmitMeshTasksEXT instruction.
Errors such as the passed variable storage class or type are already tested.
Fixes #7082
Co-Authored-by: baldurk baldurk@baldurk.org