[SPIRV] Preserve NaN, Inf, and signed zeros w/ -Gis#7693
Merged
llvm-beanz merged 3 commits intomicrosoft:mainfrom Aug 18, 2025
Merged
[SPIRV] Preserve NaN, Inf, and signed zeros w/ -Gis#7693llvm-beanz merged 3 commits intomicrosoft:mainfrom
llvm-beanz merged 3 commits intomicrosoft:mainfrom
Conversation
The `-Gis` flag opts into "strict" IEEE math rules, which include preserving NaN, Inf and signed/unsigned zeros. This change adds the SPIRV SignedZeroInfNanPreserve capability and execution mode when `-Gis` is passed to DXC. ../tools/clang/test/CodeGenSPIRV/SignedZeroInfNanPreserve.hlsl
Keenuts
reviewed
Aug 13, 2025
Collaborator
Keenuts
left a comment
Keenuts
left a comment
There was a problem hiding this comment.
Thanks! Just the extension possibility, otherwise if there is a reason not to, looks good
../tools/clang/test/CodeGenSPIRV/SignedZeroInfNanPreserve.hlsl
Keenuts
approved these changes
Aug 13, 2025
Collaborator
Keenuts
left a comment
Keenuts
left a comment
There was a problem hiding this comment.
Minor nit on the CHECK line name, otherwise LGTM,thanks!
Co-authored-by: Nathan Gauër <github@keenuts.net>
s-perron
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-Gisflag opts into "strict" IEEE math rules, which include preserving NaN, Inf and signed/unsigned zeros. This change adds the SPIRV SignedZeroInfNanPreserve capability and execution mode when-Gisis passed to DXC.