[SPIRV] Implement WaveOpsIncludeHelperLanes#7806
Merged
s-perron merged 5 commits intomicrosoft:mainfrom Oct 16, 2025
Merged
Conversation
This commit implements the `[WaveOpsIncludeHelperLanes]` attribute for the SPIR-V backend. When this attribute is applied to a shader entry point, the compiler will: - Add the `SPV_KHR_maximal_reconvergence` and `SPV_KHR_quad_control` extensions. - Add the `QuadControlKHR` capability. - Add the `MaximallyReconvergesKHR` and `RequireFullQuadsKHR` execution modes to the entry point. This change also includes new tests to verify the correctness of the implementation and updates the documentation. Fixes microsoft#7334
luciechoi
reviewed
Oct 10, 2025
tools/clang/test/CodeGenSPIRV/wave-ops-include-helper-lanes.hlsl
Outdated
Show resolved
Hide resolved
luciechoi
approved these changes
Oct 10, 2025
Keenuts
reviewed
Oct 15, 2025
Co-authored-by: Nathan Gauër <github@keenuts.net>
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Keenuts
approved these changes
Oct 15, 2025
Collaborator
Keenuts
left a comment
Keenuts
left a comment
There was a problem hiding this comment.
LGTM, just the missing test you should add before merging
Keenuts
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements the
[WaveOpsIncludeHelperLanes]attribute for the SPIR-V backend.When this attribute is applied to a shader entry point, the compiler will:
SPV_KHR_maximal_reconvergenceandSPV_KHR_quad_controlextensions.QuadControlKHRcapability.MaximallyReconvergesKHRandRequireFullQuadsKHRexecution modes to the entry point.This change also includes new tests to verify the correctness of the implementation and updates the documentation.
Fixes #7334