[SPIRV] Add diagnostic for boolean bitfields#7822
Merged
s-perron merged 2 commits intomicrosoft:mainfrom Oct 22, 2025
Merged
Conversation
Adds a diagnostic to flag the use of boolean bitfields in structs when targeting SPIR-V. This is not supported for variables that are not externally visible. This change introduces a new error message in SemaHLSL to detect and report this unsupported usage for: - Local variables - Function parameters - Static global variables A new test file is added to verify the diagnostic is triggered in these cases and not for externally visible global variables. Avoid the segfault reported in microsoft#7790.
Keenuts
approved these changes
Oct 15, 2025
Collaborator
Keenuts
left a comment
Keenuts
left a comment
There was a problem hiding this comment.
Ah that's unfortunate... LGTM
Collaborator
Author
|
@llvm-beanz Ping |
llvm-beanz
approved these changes
Oct 21, 2025
damyanp
added a commit
that referenced
this pull request
Oct 29, 2025
#7822 added a new test for spirv. This needs a `REQUIRES: spirv` to prevent it running in cases where the compiler doesn't support spirv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a diagnostic to flag the use of boolean bitfields in structs when targeting SPIR-V. This is not supported for variables that are not externally visible.
This change introduces a new error message in SemaHLSL to detect and report this unsupported usage for:
A new test file is added to verify the diagnostic is triggered in these cases and not for externally visible global variables.
Avoid the segfault reported in
#7790.