[HLSL21] Use C++ for loop scoping rules #584 #4082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should resolve microsoft#584 by adopting C++ for loop scoping rules for HLSL 2021.
pow2clk
approved these changes
Nov 16, 2021
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
Nice to squeeze this in!
I have an NFC alternative suggestion
tools/clang/lib/Parse/ParseStmt.cpp
Outdated
|
|
||
| // HLSL Change Starts - leak declarations in for control parts into outer scope | ||
| if (getLangOpts().HLSL) { | ||
| if (getLangOpts().HLSLVersion < 2020) { |
Collaborator
There was a problem hiding this comment.
It makes little difference to the end result, but referencing non-existent version 2020 makes me just a bit uncomfortable. The way these kind of checks are done elsewhere is of the form HLSLVersion < 2021.
The only reason I can think of is if someone wants to search for all the places that HLSLVersion 2021 changes the behavior and would miss this.
Collaborator
Author
There was a problem hiding this comment.
My brain is still slightly stuck in March 2020... I think today's date is 3/626/2020...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #584 by adopting C++ for loop scoping rules for
HLSL 2021.