Fix debug info generation for this (#5534)
#5536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My recent changes to correct AST inaccuracies around `this` objects caused crashes in debug info generation for `this`. This resolves the crashes by making the code behave correctly when `this` is a reference. This has no change to debug info output. The added test case should verify the same output we've always had, but is an important addition since this was not tested in our pre-merge testing. Fixes microsoft#5530 Cherry-pick of dc82ed2
python3kgae
approved these changes
Aug 11, 2023
llvm-beanz
added
the
for-release
pow2clk
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recent changes to correct AST inaccuracies around
thisobjects caused crashes in debug info generation forthis. This resolves the crashes by making the code behave correctly whenthisis a reference.This has no change to debug info output. The added test case should verify the same output we've always had, but is an important addition since this was not tested in our pre-merge testing.
Fixes #5530
Cherry-pick of dc82ed2