[SPIRV] Fix the code generated for dot4add_u8packed and dot4add_i8packed #6097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanteleev
changed the title
s-perron
approved these changes
Jan 15, 2024
sudonatalie
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #5959
The SPIR-V spec requires that
OpSDotandOpUDothave an extra Packed Vector Format operand when Vector 1 and Vector 2 are scalar integer types. My previous implementation didn't add that operand - sorry about that. The generated code worked on NVIDIA GPUs but produced incorrect ouptut on AMD and resulted in a crash on Intel ARC. This PR fixes the generated code so that it works on all three vendors' GPUs.