Add hctbuild.cmd parameter to specify the nuget config file #7785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bob80905
approved these changes
Sep 26, 2025
Collaborator
bob80905
left a comment
bob80905
left a comment
There was a problem hiding this comment.
LGTM, though nit, you could write
shift /2
goto :parse_args
instead.
Member
Author
Yeah, I was following the pattern in the file and figured that there must be some subtle reason to prefer doing it on two lines. |
hekota
approved these changes
Sep 26, 2025
damyanp
added a commit
that referenced
this pull request
Oct 26, 2025
This change allows us to control which nuget.config is used. This is to allow internal builds to override the nuget feed that's used. (cherry picked from commit 06dcb00)
damyanp
added a commit
that referenced
this pull request
Oct 28, 2025
Since we last built this branch there have been various changes to the compilers and build images we use that require code updates to allow this to continue building. These changes impact our testing / building, or guide type checking in the compiler, and so are NFC as far as the product is concerned. ### Workaround broken ARM64X / MSVC_BUILD_AS_X builds (#7827) (cherry picked from commit ea7e910) ### Use WARP from nuget by default (#7427) (cherry picked from commit 33dd542) Manually moved changes from HlslExecTestUtils.h into ExecutionTest.cpp ### Add hctbuild.cmd parameter to specify the nuget config file (#7785) (cherry picked from commit 06dcb00) ### Change type of DiagnosticHandlerTy (cherry picked from commit b05a11a) ### Type safe version of MachinePassRegistry (cherry picked from commit 4ddee81) --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Justin Bogner <mail@justinbogner.com> Co-authored-by: Serge Guelton <sguelton@quarkslab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to control which nuget.config is used.
This is to allow internal builds to override the nuget feed that's used.