Skip to content

Avoid using boolean.ToString and enum.ToString #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Avoid using boolean.ToString and enum.ToString #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a60bee3
avoid using boolean.ToString and enum.ToString
zhiyuanliang-ms Jan 15, 2025
b50a1a6
update
zhiyuanliang-ms Jan 16, 2025
3fbda46
Merge branch 'main' into zhiyuanliang/avoid-using-enum-name
zhiyuanliang-ms Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion ...soft.FeatureManagement.Telemetry.ApplicationInsights/ApplicationInsightsEventPublisher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,41 @@ private void HandleFeatureFlagEvent(ActivityEvent activityEvent)

foreach (var tag in activityEvent.Tags)
{
properties[tag.Key] = tag.Value?.ToString();
// FeatureEvaluation event schema: https://github.com/microsoft/FeatureManagement/blob/main/Schema/FeatureEvaluationEvent/FeatureEvaluationEvent.v1.0.0.schema.json
if (tag.Value is VariantAssignmentReason reason)
{
switch (reason)
{
case VariantAssignmentReason.None:
properties[tag.Key] = "None";
break;
case VariantAssignmentReason.DefaultWhenDisabled:
properties[tag.Key] = "DefaultWhenDisabled";
break;
case VariantAssignmentReason.DefaultWhenEnabled:
properties[tag.Key] = "DefaultWhenEnabled";
break;
case VariantAssignmentReason.User:
properties[tag.Key] = "User";
break;
case VariantAssignmentReason.Group:
properties[tag.Key] = "Group";
break;
case VariantAssignmentReason.Percentile:
properties[tag.Key] = "Percentile";
break;
default:
throw new ArgumentOutOfRangeException(nameof(activityEvent), "The variant assignment reason is unrecognizable.");
}
}
else if (tag.Value is bool val)
{
properties[tag.Key] = val ? "True" : "False";
}
else
{
properties[tag.Key] = tag.Value?.ToString();
}
}

_telemetryClient.TrackEvent("FeatureEvaluation", properties);
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.FeatureManagement/FeatureManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,7 @@ private void AddEvaluationActivityEvent(EvaluationEvent evaluationEvent)
Debug.Assert(evaluationEvent != null);
Debug.Assert(evaluationEvent.FeatureDefinition != null);

// FeatureEvaluation event schema: https://github.com/microsoft/FeatureManagement/blob/main/Schema/FeatureEvaluationEvent/FeatureEvaluationEvent.v1.0.0.schema.json
var tags = new ActivityTagsCollection()
{
{ "FeatureName", evaluationEvent.FeatureDefinition.Name },
Expand Down
Loading