Adds cancellationtoken to the FeatureEvaluationContext- and respects … #532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a cancellation mechanism to the feature evaluation process in the
Microsoft.FeatureManagementlibrary. The changes ensure that long-running feature evaluations can be cancelled if needed, improving the responsiveness and control over feature management operations.Key changes include:
Cancellation Token Integration:
src/Microsoft.FeatureManagement/FeatureFilterEvaluationContext.cs: Added aCancellationTokenproperty to theFeatureFilterEvaluationContextclass to support cancellation of feature evaluation operations.Cancellation Checks:
src/Microsoft.FeatureManagement/FeatureManager.cs: Added checks forcancellationToken.IsCancellationRequestedin theIsEnabledAsyncmethod to allow for early termination of the evaluation loop if cancellation is requested.src/Microsoft.FeatureManagement/FeatureManager.cs: Updated theFeatureFilterEvaluationContextinstantiation to include theCancellationTokenin theIsEnabledAsyncmethod.src/Microsoft.FeatureManagement/FeatureManager.cs: Added checks forcancellationToken.IsCancellationRequestedin theAssignVariantAsyncmethod to handle cancellation during user, group, and percentile allocations. [1] [2] [3]These updates enhance the robustness of the feature management system by allowing operations to be cancelled gracefully, which can be particularly useful in scenarios where feature evaluations are time-sensitive or resource-intensive.
Addresses #531