Skip to content

Update BasicTelemetry.sample.json #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Update BasicTelemetry.sample.json #22

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef9c067
Update BasicTelemetry.sample.json
mrm9084 Dec 17, 2024
0596afc
string to boolean
mrm9084 Dec 18, 2024
2a0dee1
Merge branch 'main' into mrm9084-patch-1
mrm9084 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Samples/BasicTelemetry.sample.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
"id": "TelemetryVariant",
"description": "",
"enabled": "true",
"enabled": true,
"conditions": {
"client_filters": []
},
Expand All @@ -19,7 +19,7 @@
"default_when_enabled": "True_Override"
},
"telemetry": {
"enabled": "true",
"enabled": true,
Copy link
Member

@avanigupta avanigupta Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this break any test?
If not, maybe we should add a test to validate this.

Copy link
Contributor Author

@mrm9084 mrm9084 Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better question for @rossgrambo or @zhiyuanliang-ms. I've updated all of them to be Boolean in this PR, but Python and Spring don't care if they are Strings or Booleans and just make them work.

Copy link
Member

@zhiyuanliang-ms zhiyuanliang-ms Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does break JS FM. I correct some of them in this PR

But I haven't use BasicTelemetry sample yet, as it was added recently.

"metadata": {
"ETag": "cmwBRcIAq1jUyKL3Kj8bvf9jtxBrFg-R-ayExStMC90",
"FeatureFlagReference": "https://fake-config-store/kv/.appconfig.featureflag/TelemetryVariant",
Expand Down
Loading