Skip to content

Conversation

@zhiyuanliang-ms
Copy link
Member

@zhiyuanliang-ms zhiyuanliang-ms commented Jan 14, 2025

The expected value of Enabled property should be "True"/"False"

Centralized testcase: ref
.NET implementation: ref
Note in C#, calling ToString on a boolean true will produce "True"

JS implementation: ref

Python implementation: in python boolean are born True and False

@mrm9084
Copy link
Contributor

mrm9084 commented Jan 14, 2025

We need to verify we have the correct answer for this as we have this PR. #22. @rossgrambo

@zhiyuanliang-ms
Copy link
Member Author

@mrm9084 The telemetry.enabled property in the feature flag configuration should be boolean. It doesn't relate to the FeatureEvaluationEvent.

@zhiyuanliang-ms zhiyuanliang-ms merged commit e822457 into main Jan 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants