[R-package] cleaned up formatting in R C/C++ files#2844
Merged
jameslamb merged 4 commits intolightgbm-org:masterfrom Mar 10, 2020
Merged
[R-package] cleaned up formatting in R C/C++ files#2844jameslamb merged 4 commits intolightgbm-org:masterfrom
jameslamb merged 4 commits intolightgbm-org:masterfrom
Conversation
StrikerRUS
reviewed
Feb 29, 2020
1912f53 to
074eae6
Compare
StrikerRUS
reviewed
Mar 4, 2020
StrikerRUS
approved these changes
Mar 4, 2020
Member
Author
Laurae2
previously requested changes
Mar 7, 2020
5891bbf to
f2c0f8f
Compare
Member
Author
|
Thanks for the reviews! |
Made the requested minor change in f2c0f8f
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a style-only PR. As I've been working on #629 , I see a few opportunities to make the current R-specific parts of
lib_lightgbma bit easier to read and edit. The diff looks a bit weird here on GitHub, but to be clear I did not change any of what the code in these files does. In this PR, I'm just proposing some indentation changes, for example taking definitions like this:and turning them into this
I also changed the language in the comment at the top of
R_object_helper.hto better reflect the current state of the R package.