[R-package] fix R CMD check NOTE about leftover files#3181
Merged
jameslamb merged 2 commits intolightgbm-org:masterfrom Jun 23, 2020
Merged
[R-package] fix R CMD check NOTE about leftover files#3181jameslamb merged 2 commits intolightgbm-org:masterfrom
jameslamb merged 2 commits intolightgbm-org:masterfrom
Conversation
Member
Author
|
it looks like this did eliminate the NOTE! https://github.com/microsoft/LightGBM/pull/3181/checks?check_run_id=797820357 |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following NOTE from
R CMD checkon Windows:It fixes this by only using
tempfile()files everywhere that examples and tests write to the file system.It also cleans up the logs in Windows R jobs. As of #3168 , I used
{processx}to run some commands and redirectstderr, to avoid transient failures.That produces hard-to-read logs like this:
This PR resolves that by assigning the result of
processx::run()and settingecho = TRUEin those calls too stream out the logs.