[R-package] factor out {ggplot2}#3224
Merged
guolinke merged 6 commits intolightgbm-org:masterfrom Jul 20, 2020
Merged
Conversation
StrikerRUS
reviewed
Jul 13, 2020
Collaborator
StrikerRUS
left a comment
There was a problem hiding this comment.
LGTM for the idea to drop heavy dependency!
f884a2c to
69bcdcf
Compare
guolinke
approved these changes
Jul 20, 2020
Collaborator
Member
Author
|
oooooooooooooooo yes we can! I forgot about those. Yes I'll remove them right now. We can always add back if we introduce new I'll open a PR right now, thanks for the suggestion! |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today the R package has a
Suggestsdependency on{ggplot2}. This is only for one demo,demo/leaf_stability.R. This pull request proposes factoring it out and replacing it withbaseR code.This will allow us to cut out this
R CMD checkNOTE:More importantly, it's an expensive dependency that anyone installing the
Suggestsdependencies of{lightgbm}has to pay for.Some of these plots look different from the comments around them, but this PR does not address that...it can be addressed in #1944 . This PR is limited to just factoring out
{ggplot2}, to make the package as lightweight as possible when it goes to CRAN (work-in-progress, #629 ).Comparisons
I've included before and after screenshots for each plot below. The "Depth Density" plots look noticeably different, I think because of changes in how
geom_density()works in{ggplot2}.demo/leaf_stability.Rwas written more than 3 years ago.Thanks to @alistaire47 for helping me with
{ggplot2}stuff 😀plot 1
before

after
plot 2
before
after
plot 3
before
after
plot 4
before
after
plot 5
before
after
plot 6
before
after
plot 7
before
after
plot 8
before
after