[R-package] allow R to pick between -fPIC and -fpic for CRAN package#3261
[R-package] allow R to pick between -fPIC and -fpic for CRAN package#3261StrikerRUS merged 3 commits intolightgbm-org:masterfrom
Conversation
|
I'm glad to see configuration simplification! But I'm not happy with that we are getting more and more differences in code compilation for manual builds and CRAN ones. This means we will have to ask users how they installed LightGBM to debug reported issues. |
I think we will already have to do that anyway, and that the maintenance burden is well worth it. I think our current build process involving |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |



I think we can remove setting
CPICFLAGSinMakevars.inandMakevars.win.inin the R package. I noticed in the logs from R Hub (#629 (comment)) that my choioce was being ignored anyway...-fpicis used in many of the jobs.Re-reading "Writing R Extensions", I see that I probably should have been using
CXX11PICFLAGS.In this PR, I propose just removing
CPICFLAGSfrom these Makefiles and using whatever values R chooses based on the environment it is installed in. That should slightly simplify our configuration and reduce the risk of the CRAN package failing checks on the many obscure environments CRAN uses for testing.