Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@microsoft/objectstoreprovider",
"version": "0.8.0",
"version": "0.8.1",
"description": "A cross-browser object store library",
"author": "Mukundan Kavanur Kidambi <mukav@microsoft.com>",
"scripts": {
Expand Down
17 changes: 13 additions & 4 deletions src/IndexedDbProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1347,8 +1347,9 @@ class IndexedDbIndex extends DbIndexFTSFromRangeQueries {
highRangeExclusive?: boolean,
reverseOrSortOrder?: boolean | QuerySortOrder,
limit?: number,
offset?: number
): Promise<ItemType[]> {
offset?: number,
forceDisableGetAllRecords = false
): Promise<ItemType[] & { isFromNewGetAllReverseMethod?: boolean }> {
const keyRange = attempt(() => {
return this._getKeyRangeForRange(
keyLowRange,
Expand All @@ -1373,7 +1374,10 @@ class IndexedDbIndex extends DbIndexFTSFromRangeQueries {
return IndexedDbProvider.WrapRequest(this._store.getAll(keyRange, limit));
}

const shouldUseGetAllRecords = this.idbConfigs?.useGetAllRecordsForGetRange;
// use getAllRecords if it is allowed by config during init, and caller does not want to disable it
const shouldUseGetAllRecords =
this.idbConfigs?.useGetAllRecordsForGetRange &&
!forceDisableGetAllRecords;
if (
shouldUseGetAllRecords &&
!!this._store.getAllRecords &&
Expand All @@ -1392,7 +1396,12 @@ class IndexedDbIndex extends DbIndexFTSFromRangeQueries {

return IndexedDbProvider.WrapRequest(
this._store.getAllRecords(query_options)
);
).then((result) => {
if (!!result) {
(result as any).isFromNewGetAllReverseMethod = true;
}
return result;
});
}

const req = this._store.openCursor(keyRange, reverse ? "prev" : "next");
Expand Down
13 changes: 8 additions & 5 deletions src/ObjectStoreProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,9 @@ export interface DbIndex {
highRangeExclusive?: boolean,
reverseOrSortOrder?: boolean | QuerySortOrder,
limit?: number,
offset?: number
): Promise<ItemType[]>;
offset?: number,
forceDisableGetAllRecords?: boolean
): Promise<ItemType[] & { isFromNewGetAllReverseMethod?: boolean }>;
getKeysForRange(
keyLowRange: KeyType,
keyHighRange: KeyType,
Expand Down Expand Up @@ -374,8 +375,9 @@ export abstract class DbProvider {
highRangeExclusive?: boolean,
reverseOrSortOrder?: boolean | QuerySortOrder,
limit?: number,
offset?: number
): Promise<ItemType[]> {
offset?: number,
forceDisableGetAllRecords?: boolean
): Promise<ItemType[] & { isFromNewGetAllReverseMethod?: boolean }> {
return this._getStoreIndexTransaction(storeName, false, indexName).then(
(index) => {
return index.getRange(
Expand All @@ -385,7 +387,8 @@ export abstract class DbProvider {
highRangeExclusive,
reverseOrSortOrder,
limit,
offset
offset,
forceDisableGetAllRecords
);
}
);
Expand Down
Loading