-
Notifications
You must be signed in to change notification settings - Fork 270
Closed
Labels
priority:p0Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrsBlocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrstype:bugA broken experienceA broken experience
Description
Related to microsoft/kiota#5468
In the event an input document has a path with path parameters shared across the operation like this.
/test/{id}:
get:
summary: Summary for test path with id that is longer than 50 characters
description: description for test path with id
operationId: test.WithId
responses:
'200':
description: test
delete:
summary: Summary for test path with id that is longer than 50 characters
description: description for test path with id
operationId: test.WithId
responses:
'200':
description: test
parameters:
- name: id
in: path
required: true
description: The id of the test
schema:
type: integer
format: int32The openApiFilterService will treat the parameter as unique for each operation and add a duplicate entry for each operation. like this .
'/test/{id}':
get:
summary: Summary for test path with id that is longer than 50 characters
description: description for test path with id
operationId: test_WithId
responses:
'200':
description: test
delete:
summary: Summary for test path with id that is longer than 50 characters
description: description for test path with id
operationId: test_WithId
responses: { }
parameters:
- name: id
in: path
description: The id of the test
required: true
style: simple
schema:
type: integer
format: int32
- name: id
in: path
description: The id of the test
required: true
style: simple
schema:
type: integer
format: int32At first glance , this looks to be caused by the OperationSearch that adds the pathItem parameter to the search result of each operation.
| Parameters = pathItem.Parameters, |
When merging back the results, the FilterServices does not check for uniqueness but adds all the parameters blindly to the filtered document.
| pathItem.Parameters.Add(parameter); |
Metadata
Metadata
Assignees
Labels
priority:p0Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrsBlocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrstype:bugA broken experienceA broken experience