Skip to content

Fix: Creating too many zones causes a crash #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ivan100sic merged 1 commit into from
Mar 5, 2020
Merged

Fix: Creating too many zones causes a crash #1337

ivan100sic merged 1 commit into from
Mar 5, 2020

Conversation

@ivan100sic
Copy link
Contributor

@ivan100sic ivan100sic commented Feb 20, 2020

Summary of the Pull Request

This fixes #1336

References

PR Checklist

  • [] Applies to FancyZones crashes when there are too many zones #1336
  • [] CLA signed. If not, go over here and sign the CLA
  • [] Tests added/passed
  • [] Requires documentation to be updated
  • [] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Tested by creating ~100 zones using the GridEditor, clicked "Apply/Save" and everything works.

@ivan100sic
Fix too many zones crashing
bdb5eb6 
Apparent fix for an issue where creating too many zones causes a crash
@ivan100sic ivan100sic changed the title Fix: Too many zones causes a crash Fix: Creating too many zones causes a crash Feb 20, 2020
@enricogior enricogior added Status-In progress This issue or work-item is under development and removed Status-In progress This issue or work-item is under development labels Feb 24, 2020
@ivan100sic ivan100sic merged commit 8a22da0 into microsoft:master Mar 5, 2020
@enricogior enricogior mentioned this pull request Mar 5, 2020
Closed
@ivan100sic ivan100sic deleted the fix-too-many-zones-crash branch March 5, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefansjfw stefansjfw Awaiting requested review from stefansjfw

1 more reviewer

@vldmr11080 vldmr11080 vldmr11080 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FancyZones crashes when there are too many zones

3 participants

@ivan100sic @vldmr11080 @enricogior