Skip to content

Fix for issue 448#548

Merged
enricogior merged 1 commit intomicrosoft:masterfrom
enricogior:issue-448
Oct 23, 2019
Merged

Fix for issue 448#548
enricogior merged 1 commit intomicrosoft:masterfrom
enricogior:issue-448

Conversation

@enricogior
Copy link
Contributor

Summary of the Pull Request

Don't quit the FZ editor if no layout is selected when clicking on the "Edit selected layout".
Don't exit when clicking on "Apply" if no layout is selected.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Credit to @alexr3 for the fix. Alex provided a more extensive fix that disables the button when no layout is selected, but it requires more changes to the XAML and we preferred to avoid that now.

Validation Steps Performed

Manual test.

…e "Edit selected layout"

don't exit when clicking on "Apply" if no layout is selected

Credit to @alexr3 for the fix. Alex provided a more extensive fix that  disable the button when no layout  is selected, but it requires more changes to the XAML and we preferred to avoid that now.
@enricogior enricogior requested a review from bzoz October 23, 2019 16:37
Copy link
Contributor

@bzoz bzoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enricogior enricogior merged commit 57cd5b5 into microsoft:master Oct 23, 2019
@enricogior enricogior deleted the issue-448 branch March 18, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FancyZones Editor unexpectedly closes when trying to edit layout but no layout is selected

2 participants