Skip to content

Conversation

@yuyoyuppe
Copy link
Contributor

@yuyoyuppe yuyoyuppe commented Dec 13, 2019

Summary of the Pull Request

  • fix compilation errors in the PowerToy project template
  • include it to the main solution to keep it up to date
  • create a separate solution to easily export/sign it later
  • update exported .zip and clarify usage in README

PR Checklist

Validation Steps Performed

Built the template project, added new PowerToy via template to the main solution, built it.
template

@yuyoyuppe yuyoyuppe requested a review from enricogior December 13, 2019 15:06
if (settings.is_bool_value(L"bool_toggle_1")) {
g_settings.bool_prop = settings.get_bool_value(L"bool_toggle_1");
}
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More commented out code that is badly formatted

@enricogior
Copy link
Contributor

Small changes and we are good to merge, nice work!

@yuyoyuppe yuyoyuppe force-pushed the project_template_update branch from 96ed0af to 6259f93 Compare December 16, 2019 09:47
@yuyoyuppe yuyoyuppe requested a review from enricogior December 16, 2019 09:47
@yuyoyuppe yuyoyuppe merged commit 7e91121 into microsoft:master Dec 16, 2019
@yuyoyuppe yuyoyuppe deleted the project_template_update branch December 16, 2019 10:12
yuyoyuppe added a commit that referenced this pull request Jan 23, 2020
* Add PowerToy project template to the PowerToys solution
* Update PowerToy project template and create a separate solution for it
yuyoyuppe added a commit that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants