-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Closed
Labels
Issue-BugSomething isn't workingSomething isn't workingResolution-Fix CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.
Description
After the changes done in #5970 (Update .gitattributes) a lot of file changes start appearing when the files were not touched.
@crutkas Were you still converting some files? Looks like not all files in the solution are converted.
ℹ Computer information
- Windows Sandbox (Build 20185)
- Git version 2.28.0.windows.1
📝 Provide detailed reproduction steps (if any)
- Ensure git is installed (default settings)
- Ensure Visual Studio (Code) is installed (default settings)
- Clone the solution
- Open the solution in Visual Studio (Code)
✔️ Expected result
No Modified Files
❌ Actual result
A lot of file changes (131 to be precise)
📷 Screenshots
A git diff on one of the files shows the following
git diff --color --word-diff-regex=. src/core/Microsoft.PowerToys.Settings.UI/Views/KeyboardManagerPage.xaml.csdiff --git a/src/core/Microsoft.PowerToys.Settings.UI/Views/KeyboardManagerPage.xaml.cs b/src/core/Microsoft.PowerToys.Settings.UI/Views/KeyboardManagerPage.xaml.cs
index 2326470..d741823 100644
--- a/src/core/Microsoft.PowerToys.Settings.UI/Views/KeyboardManagerPage.xaml.cs
+++ b/src/core/Microsoft.PowerToys.Settings.UI/Views/KeyboardManagerPage.xaml.cs
@@ -1,23 +1,23 @@
<EF><BB><BF>// Copyright (c) Microsoft Corporation[-^M-]
// The Microsoft Corporation licenses this file to you under the MIT license.[-^M-]
// See the LICENSE file in the project root for more information.[-^M-]
[-^M-]
using Microsoft.PowerToys.Settings.UI.ViewModels;[-^M-]
using Windows.UI.Xaml.Controls;[-^M-]
[-^M-]
namespace Microsoft.PowerToys.Settings.UI.Views[-^M-]
{[-^M-]
/// <summary>[-^M-]
/// An empty page that can be used on its own or navigated to within a Frame.[-^M-]
/// </summary>[-^M-]
public sealed partial class KeyboardManagerPage : Page[-^M-]
{[-^M-]
public KeyboardManagerViewModel ViewModel { get; } = new KeyboardManagerViewModel();[-^M-]
[-^M-]
public KeyboardManagerPage()[-^M-]
{[-^M-]
InitializeComponent();[-^M-]
DataContext = ViewModel;[-^M-]
}[-^M-]
}[-^M-]
}[-^M-]Note the "[-^M-]" which mentions newline changes. (Removal of the "newline" character)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Issue-BugSomething isn't workingSomething isn't workingResolution-Fix CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.
