Better-looking feedback message for the take command. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcCote
force-pushed
the
enh_better_looking_take_action
branch
3 times, most recently
from
f1efab0 to
9261988
Compare
tavianator
previously approved these changes
Aug 27, 2018
MarcCote
force-pushed
the
enh_better_looking_take_action
branch
from
9261988 to
0bb2766
Compare
Contributor
Author
|
@tavianator I squashed the two commits into one. Also, removed a forgotten debug breakpoint. |
tavianator
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offers a better-looking feedback message for reporting the "take" and "drop" actions. For instance, instead of simply saying "Taken" or "Dropped" it nows prints something like