Skip to content

Remove unimplemented PushSubscriptionChangeEvent #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove unimplemented PushSubscriptionChangeEvent #944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01cda51
Remove unimplemented PushSubscriptionChangeEvent
saschanaz Oct 25, 2020
4600fd4
Merge remote-tracking branch 'upstream/master' into remove-onpushsub
saschanaz Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions baselines/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,11 +362,6 @@ interface PushPermissionDescriptor extends PermissionDescriptor {
userVisibleOnly?: boolean;
}

interface PushSubscriptionChangeEventInit extends ExtendableEventInit {
newSubscription?: PushSubscription;
oldSubscription?: PushSubscription;
}

interface PushSubscriptionJSON {
endpoint?: string;
expirationTime?: number | null;
Expand Down Expand Up @@ -2702,16 +2697,6 @@ declare var PushSubscription: {
new(): PushSubscription;
};

interface PushSubscriptionChangeEvent extends ExtendableEvent {
readonly newSubscription: PushSubscription | null;
readonly oldSubscription: PushSubscription | null;
}

declare var PushSubscriptionChangeEvent: {
prototype: PushSubscriptionChangeEvent;
new(type: string, eventInitDict?: PushSubscriptionChangeEventInit): PushSubscriptionChangeEvent;
};

interface PushSubscriptionOptions {
readonly applicationServerKey: ArrayBuffer | null;
readonly userVisibleOnly: boolean;
Expand Down Expand Up @@ -2913,7 +2898,6 @@ interface ServiceWorkerGlobalScopeEventMap extends WorkerGlobalScopeEventMap {
"notificationclick": NotificationEvent;
"notificationclose": NotificationEvent;
"push": PushEvent;
"pushsubscriptionchange": PushSubscriptionChangeEvent;
"sync": SyncEvent;
}

Expand All @@ -2928,7 +2912,6 @@ interface ServiceWorkerGlobalScope extends WorkerGlobalScope {
onnotificationclick: ((this: ServiceWorkerGlobalScope, ev: NotificationEvent) => any) | null;
onnotificationclose: ((this: ServiceWorkerGlobalScope, ev: NotificationEvent) => any) | null;
onpush: ((this: ServiceWorkerGlobalScope, ev: PushEvent) => any) | null;
onpushsubscriptionchange: ((this: ServiceWorkerGlobalScope, ev: PushSubscriptionChangeEvent) => any) | null;
onsync: ((this: ServiceWorkerGlobalScope, ev: SyncEvent) => any) | null;
readonly registration: ServiceWorkerRegistration;
readonly serviceWorker: ServiceWorker;
Expand Down
8 changes: 8 additions & 0 deletions inputfiles/removedTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@
"PasswordCredential": null,
"Position": null,
"PositionError": null,
"PushSubscriptionChangeEvent": null,
"ReadableByteStreamController": null,
"ReadableStream": {
"iterator": null
Expand Down Expand Up @@ -276,6 +277,13 @@
}
}
},
"ServiceWorkerGlobalScope": {
"properties": {
"property": {
"onpushsubscriptionchange": null
}
}
},
"ShadowRoot": {
"properties": {
"property": {
Expand Down