Skip to content

Fix: Playground handle bigint in logs #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Fix: Playground handle bigint in logs #3169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7edb74e
chore: refactor Playground handling undefined in logs
lukaw3d Jun 28, 2024
5e6af09
Fix: Playground handle bigint in logs
lukaw3d Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/playground/src/sidebar/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,13 +218,18 @@ function rewireLoggingToElement(
const nameWithoutObject = name && name === "Object" ? "" : htmlEscape(name)
const prefix = nameWithoutObject ? `${nameWithoutObject}: ` : ""

// JSON.stringify omits any keys with a value of undefined. To get around this, we replace undefined with the text __undefined__ and then do a global replace using regex back to keyword undefined
textRep =
prefix +
JSON.stringify(arg, (_, value) => (value === undefined ? "__undefined__" : value), 2).replace(
/"__undefined__"/g,
"undefined"
)
JSON.stringify(
arg,
(_, value) => {
// JSON.stringify omits any keys with a value of undefined. To get around this, we replace undefined with the text __undefined__ and then do a global replace using regex back to keyword undefined
if (value === undefined) return "__undefined__"
if (typeof value === 'bigint') return `BigInt('${value.toString()}')`
return value
},
2
).replace(/"__undefined__"/g, "undefined")

textRep = htmlEscape(textRep)
} else {
Expand Down