Poor error span for unclosed JSX tags in the presence of whitespace/comments

[DanielRosenwasser]

let Foo = {
  Bar() {
    
  }
}

let x = <    Foo.Bar >Hello

Expected: An error span like

let x = <    Foo.Bar >Hello
             ~~~~~~~

Actual: An error span like

let x = <    Foo.Bar >Hello
         ~~~~~~~~~~~

[AGMETEOR]

Would like to try this one out...

[DanielRosenwasser]

Go for it! I'd try running the change to see if any tests are affected first, and if not, add the one in the example in a a file named tests/cases/compiler/errorSpanForUnclosedJsxTag.tsx

[AGMETEOR]

@DanielRosenwasser implemented a solution for this. Will be raising a PR for review shortly :)

[AGMETEOR]

Hi @DanielRosenwasser , I opened a PR for this issue :)

[DanielRosenwasser]

Thanks @AGMETEOR!