Date.toLocaleDateString signature incorrect

[gwicksted]

It is incorrectly defined as no arguments in both lib.d.ts as well as the most recent DefinitelyTyped date.format.d.ts

See spec

I believe it should be this:

toLocaleDateString(locales?: string[] | string, options?: Intl.DateTimeFormatOptions): string;

JavaScript example:

var date = new Date(Date.UTC(2015, 8, 12, 9, 41, 0));
console.log(date.toLocaleDateString(['en-US'], { month: "2-digit" }));
// will write "08" to the console

NOTE: I believe toLocaleTimeString has the same problem.

I am willing to submit a pull request -- I'm just not that familiar with writing jake tests.

[danquirk]

We generally don't write tests for lib.d.ts changes so you don't need to worry about that part.

[mhegazy]

@gwicksted I would add the overload in https://github.com/Microsoft/TypeScript/blob/master/src/lib/intl.d.ts, since it is using options of a type defined in that file.

[gwicksted]

Please review - I also added a parameter to the DateTimeFormatOptions that I noticed was missing and made a minor edit to the comments to reflect date + time formatting (toLocaleString) vs just date formatting (toLocaleDateString).

[mhegazy]

thanks @gwicksted !