switch enums in protocol to unions of literal types #11651
Conversation
| if (extraDeclarations) { | ||
| protocolDts += extraDeclarations; | ||
| } | ||
| protocolDts += "\nimport protocol = ts.server.protocol;"; |
There was a problem hiding this comment.
export as namespace protocol
src/server/editorServices.ts
Outdated
| } | ||
|
|
||
| export function convertCompilerOptions(protocolOptions: protocol.ExternalProjectCompilerOptions): CompilerOptions & protocol.CompileOnSaveMixin { | ||
| protocolOptions.target = convertCompilerOptionEnum(targetCommandLineOption, protocolOptions.target); |
There was a problem hiding this comment.
can we do this in a more generic way? we have the types for the options as a whole, so we can just go through them once and build a map of things we want to convert, then do this on the fly?
There was a problem hiding this comment.
not sure that I understand what you mean and how it will be beneficial. We already reuse maps that we've populated for compiler options.
There was a problem hiding this comment.
now if i add a new compiler option, i need to add it to commandline-parser and here as well. can i do it in one place?
switch enums in protocol to unions of literal types
|
|
||
| const compilerOptionConverters = prepareConvertersForEnumLikeCompilerOptions(optionDeclarations); | ||
| const indentStyle = createMap({ | ||
| "none": IndentStyle.None, |
There was a problem hiding this comment.
Why use the lowercase names here and call protocolOptions.indentStyle.toLowerCase() later? Why not just use "None" etc.?
There was a problem hiding this comment.
because we cannot guarantee that all callers will use proper casing for these values. It can be enforced for .ts sources but other consumers cannot be checked so we try to be tolerant
// cc @dbaeumer, @mhegazy
This PR:
protocol.d.tsto modulenow generated
protocol.d.tslooks like this