Use type predicate for getFirstJSDocTag #22573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
getFirstJSDocTag
branch
2 times, most recently
from
42dfc16 to
8e6542d
Compare
sandersn
approved these changes
Mar 14, 2018
ghost
commented
Mar 14, 2018
| } | ||
|
|
||
| /** Gets the JSDoc augments tag for the node if present */ | ||
| export function getJSDocAugmentsTag(node: Node): JSDocAugmentsTag | undefined { |
There was a problem hiding this comment.
@sandersn These functions are so simple now, and only used in a few places, maybe we should just inline them?
There was a problem hiding this comment.
Aren't they part of the public API? Otherwise I'd say yes.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets us avoid a lot of casts (that were also invalid with
--strictNullChecks).