Ensure we find export default declaration targets if we search for them by name #2553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/compiler/checker.ts
Outdated
Contributor
There was a problem hiding this comment.
what about adding function to avoid duplicating the same checks in two places?
function getLocalSymbolForExportDefault(symbol: Symbol) {
return symbol.valueDeclaration && (symbol.valueDeclaration.flags & NodeFlags.Default) && symbol.valueDeclaration.localSymbol ? symbol.valueDeclaration.localSymbol : undefined;
}
Contributor
Author
There was a problem hiding this comment.
I did that, but then the checks span multiple lines, and they are not much prettier.
Contributor
There was a problem hiding this comment.
I;m not very concerned about multiline checks - just would like to have these non-obvious tests in one place.
Conflicts: src/compiler/utilities.ts
mhegazy
added a commit
that referenced
this pull request
Apr 1, 2015
Ensure we find export default declaration targets if we search for them by name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2538
The binder creates two symbols for each exported declaration, one that is local and one that is exported. The local ones have a different symbol flags, to ensure we catch any redefinition, while the exported ones are the ones used after that. This works because we always search in the module.exports when looking up names.
this breaks in the case of
export default classorexport default functionas the names of the two symbols are not the same. the name of the local symbol is the name of the declaration, where as the name of the exported symbol is "default".this change ensures we are looking for these "default" properties if they exist.