Added type inference to Object.keys type definition. #25832
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: https://stackoverflow.com/questions/51446585/type-array-of-keys-of-a-particular-interface In short, with the current type of Object.keys: `keys(o: {}): string[]`, typescript does not know what the values of `o` are, so if I pass Object.keys from a parent React.Component to a child and type definition of this particular child's prop is specified as `(keyof InterfaceOfO)[]`, I get a `TypeError: Type 'string[]' is not assignable to type '("whatever" | "keys" | "of" | "o" | "are")[].
Object.values has 2 type definitions: https://github.com/Microsoft/TypeScript/blob/master/lib/lib.es2017.object.d.ts This commit returns the current type definition of Object.keys, adding it in addition to the proposed one in attempt to resolve the "non-successful checks" reported by the bot.
Contributor
4 tasks
5 tasks
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: https://stackoverflow.com/questions/51446585/type-array-of-keys-of-a-particular-interface
In short, with the current type of Object.keys:
keys(o: {}): string[], typescript does not know what the values ofoare, so if I pass Object.keys from a parent React.Component to a child and type definition of this particular child's prop is specified as(keyof InterfaceOfO)[], I get a `TypeError: Type 'string[]' is not assignable to type '("whatever" | "keys" | "of" | "o" | "are")[].Fixes #