tsconfig parsing in Language Service #2877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 21, 2015 13:24
add a callback to enumerate files in a directory
| @@ -299,7 +299,7 @@ module ts { | |||
| * @param basePath A root directory to resolve relative path entries in the config | |||
| * file to. e.g. outDir | |||
| */ | |||
| export function parseConfigFile(json: any, basePath?: string): ParsedCommandLine { | |||
| export function parseConfigFile(json: any, host: ParseConfigHost, basePath?: string): ParsedCommandLine { | |||
There was a problem hiding this comment.
make basePath required.
|
Please use readConfigFile instead of another JSON.parse |
| return { | ||
| options: {}, | ||
| files: [], | ||
| errors: [realizeDiagnostic(result.error, '/r/n')] |
| @@ -188,6 +194,7 @@ module ts { | |||
|
|
|||
| export interface CoreServicesShim extends Shim { | |||
| getPreProcessedFileInfo(fileName: string, sourceText: IScriptSnapshot): string; | |||
| getTSConfigFileInfo(fileName: string, sourceText: IScriptSnapshot): string; | |||
There was a problem hiding this comment.
getConfigFileInfo and lose the TS part
|
Thanks 👍 |
| try { | ||
| var text = sys.readFile(fileName); | ||
| return /\S/.test(text) ? JSON.parse(text) : {}; | ||
| return parseConfigFileText(fileName, text); |
There was a problem hiding this comment.
this needs to move out of the try.
paulvanbrenk
added a commit
that referenced
this pull request
Apr 23, 2015
This adds a method to the language service to parse a tsconfig file and correctly calculate the initial collection of files to consider. We expect the 'host' to find the files in the file system.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method to the language service to parse a tsconfig file and correctly calculate the initial collection of files to consider.
We expect the 'host' to find the files in the file system.