Skip to content

Always generate configFileDiag if file is going to be added to configured project #37443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2020
Merged

Always generate configFileDiag if file is going to be added to configured project #37443

merged 1 commit into from
Mar 18, 2020

Conversation

@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Mar 17, 2020

Fixes #30623

sheetalkamat
sheetalkamat commented Mar 17, 2020
View reviewed changes
src/testRunner/unittests/tsserver/projectErrors.ts
]);
openFilesForSession([file], serverEventManager.session);
// We generate only if project is created when opening file from the project
serverEventManager.hasZeroEvent("configFileDiag");
Copy link
Member Author

@sheetalkamat sheetalkamat Mar 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjbvz Want you to ensure that this still holds. That is if file is opened from configured project, configFileDiag is generated only if project is created as part of the open operation

@sheetalkamat
Copy link
Member Author

sheetalkamat commented Mar 17, 2020

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 17, 2020 •
edited
Loading

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 4473323. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 17, 2020 •
edited
Loading

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/68417/artifacts?artifactName=tgz&fileId=A217C74B34E9294663D724B2B95A52CB64DDCC10A8CCB7DF1F2E4929132137BE02&fileName=/typescript-3.9.0-insiders.20200317.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

@mjbvz
Copy link
Contributor

mjbvz commented Mar 17, 2020

Tested in VS Code. Looks like we show the diagnostic that TS server generates with this change:

Screen Shot 2020-03-17 at 3 54 02 PM

@sheetalkamat sheetalkamat merged commit 2df421b into master Mar 18, 2020
@sheetalkamat sheetalkamat deleted the configFileDiag branch March 18, 2020 17:39
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@mjbvz mjbvz mjbvz approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@sheetalkamat sheetalkamat

Labels

Author: Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

configFileDiag response not generated until after config file is saved

5 participants

@sheetalkamat @typescript-bot @mjbvz @andrewbranch