Skip to content

Support rich compile on save emit reponse so we can report diagnostics #37462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2020
Merged

Support rich compile on save emit reponse so we can report diagnostics #37462

merged 1 commit into from
Mar 19, 2020

Conversation

@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Mar 18, 2020

Fixes #30739

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 18, 2020

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

amcasey
amcasey approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would find it reassuring to have it tested it in VS (@minestarks?)

@sheetalkamat
Copy link
Member Author

sheetalkamat commented Mar 19, 2020

@uniqueiniquity can you please try it out and see if this works. Would like to get this in for 3.9

@uniqueiniquity
Copy link
Contributor

uniqueiniquity commented Mar 19, 2020

@sheetalkamat trying it out now

@uniqueiniquity
Copy link
Contributor

uniqueiniquity commented Mar 19, 2020 •
edited
Loading

@sheetalkamat, I've validated that compile on save still works when running with these changes in VS.
EDIT: that is, with the new flag not set.

@sheetalkamat sheetalkamat merged commit 7e07a2b into master Mar 19, 2020
@sheetalkamat sheetalkamat deleted the richCompileOnSave branch March 19, 2020 21:03
@uniqueiniquity
Copy link
Contributor

uniqueiniquity commented Mar 19, 2020

FWIW, just validated that if VS is updated to provide the new flag and handle the return type, diagnostics are returned in the scenario from #30739

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@uniqueiniquity uniqueiniquity Awaiting requested review from uniqueiniquity

1 more reviewer

@amcasey amcasey amcasey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sheetalkamat sheetalkamat

@amcasey amcasey

Labels

Author: Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

compileOnSaveEmitFile silently failing

5 participants

@sheetalkamat @typescript-bot @uniqueiniquity @amcasey