Skip to content

Avoid check for union keys #39314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2020
Merged

Avoid check for union keys #39314

merged 2 commits into from
Jul 6, 2020

Conversation

@Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Jun 29, 2020 •
edited
Loading

Fixes #39246

andrewbranch
andrewbranch approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kingwl!

@sandersn
Copy link
Member

sandersn commented Jul 2, 2020

@Kingwl this is ready to go after you resolve the conflicts in checker.

@sandersn sandersn merged commit 4533652 into microsoft:master Jul 6, 2020
@Kingwl Kingwl deleted the avoid_union_keys_type_deprecated branch July 7, 2020 03:43
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn sandersn sandersn approved these changes

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@deprecated appears for any element access that might access a deprecated member

3 participants

@Kingwl @sandersn @andrewbranch