Support loading of child project if found project is not pure solution has some of its own files and project references #39613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested review from
DanielRosenwasser,
RyanCavanaugh,
amcasey,
andrewbranch and
sandersn
typescript-bot
added
the
For Milestone Bug
andrewbranch
approved these changes
Jul 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps when the default config found does not directly reference the opened file (but project is not pure solution, meaning project has its own files in addition to references) but one of the referenced project has the project that is default for that info.
Fixes #38605
Note that this works on top of #39593 and is better that way since we want to give user control over which solution/project can load referenced projects.