feat(44736): Go-to-def on override should navigate to the overridden method #44740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kingwl
reviewed
Jun 25, 2021
Kingwl
reviewed
Jun 25, 2021
a-tarasyuk
force-pushed
the
feat/44736
branch
4 times, most recently
from
e05b1c1 to
a0c2637
Compare
uniqueiniquity
approved these changes
Jun 26, 2021
Contributor
uniqueiniquity
left a comment
uniqueiniquity
left a comment
There was a problem hiding this comment.
Looks great from an intended behavior perspective!
I'll let someone who knows more about the implementation sign off before merging.
Kingwl
reviewed
Jun 28, 2021
Kingwl
reviewed
Jun 28, 2021
andrewbranch
approved these changes
Jun 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44736