Skip to content

Forbid duplicate tests only in compiler+fourslash runner #44752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2021
Merged

Forbid duplicate tests only in compiler+fourslash runner #44752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e99b8d
Forbid duplicate tests only in compiler runner
sandersn Jun 25, 2021
3a69eba
Include fourslash, but exempt shims and server
sandersn Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/testRunner/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,17 @@ namespace Harness {
const seen = new Map<string, string>();
const dupes: [string, string][] = [];
for (const runner of runners) {
for (const sf of runner.enumerateTestFiles()) {
const full = typeof sf === "string" ? sf : sf.file;
const base = vpath.basename(full).toLowerCase();
// exempt fourslash-fourslash conflicts since they're less likely to emit baselines
if (seen.has(base) && !(/fourslash/.test(seen.get(base)!) && /fourslash/.test(full))) {
dupes.push([seen.get(base)!, full]);
}
else {
seen.set(base, full);
if (runner instanceof CompilerBaselineRunner || runner instanceof FourSlashRunner) {
for (const sf of runner.enumerateTestFiles()) {
const full = typeof sf === "string" ? sf : sf.file;
const base = vpath.basename(full).toLowerCase();
// allow existing dupes in fourslash/shims and fourslash/server
if (seen.has(base) && !/fourslash\/(shim|server)/.test(full)) {
dupes.push([seen.get(base)!, full]);
}
else {
seen.set(base, full);
}
}
}
runner.initializeTests();
Expand Down