Modify synthetic default generation code for dual-mode module resolution #46156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
approved these changes
Oct 1, 2021
Member
|
I'm going to skip the sync. @typescript-bot cherry-pick this to release-4.5 and LKG |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Member
|
Ah I just saw #46159. Maybe we'll do a full sync. 😭 |
Collaborator
|
Hey @DanielRosenwasser, I've opened #46162 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Oct 1, 2021
Component commits: 7e3a80a Modify synthetic default generation code for dual-mode module resolution
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module: node12was relying on our existingesModuleInteroplogic for determining if modules should have a syntheticdefaultmember equivalent to the module shape - this is correct for a cjs format import of another cjs file, however should be wholly disabled for esm/esm imports, and is overcomplicated for esm/cjs imports (which simply always have a synthetic default, no heuristics needed). In this PR, I add the missing logic to our synthetic default selection code to handle these new modal imports.