Enable auto imports in member snippet completions #46592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
commented
Oct 29, 2021
| "category": "Message", | ||
| "code": 90053 | ||
| }, | ||
| "Includes imports of types referenced by '{0}'": { |
Member
Author
There was a problem hiding this comment.
Note that this is never surfaced by the VS Code UI 🤷
I think that's totally fine, I only made it because the protocol made me have a message to go along with the fix
andrewbranch
requested review from
DanielRosenwasser,
gabritto,
mjbvz and
sandersn
gabritto
approved these changes
Oct 29, 2021
Member
gabritto
left a comment
gabritto
left a comment
There was a problem hiding this comment.
I think this makes sense for a quick win, and like you said, we can deduplicate the import adder efforts later. Thanks ✨
|
|
||
| if (actual.insertText !== expected.insertText) { | ||
| this.raiseError(`Expected completion insert text to be ${expected.insertText}, got ${actual.insertText}`); | ||
| this.raiseError(`Completion insert text did not match: ${showTextDiff(expected.insertText || "", actual.insertText || "")}`); |
Member
There was a problem hiding this comment.
that's awesome, I've been needing this for a while
Member
Author
There was a problem hiding this comment.
I usually try to fix things that annoy me about fourslash, it has definitely paid off even if I were the only person using it 😅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #46568
This duplicates the work of calculating auto-imports between
CompletionInfoandCompletionDetailsin order to support this without a last-minute protocol change and VS Code update. During 4.6, we can actually just update the protocol and leverage the work done inCompletionInfo, removing theCompletionDetailswork, but I think this is alright for the moment.Kapture.2021-10-29.at.13.36.07.mp4